[pLog-svn] r619 - plog/trunk/class/plugin

Oscar Renalias oscar at renalias.net
Thu Dec 30 13:48:13 GMT 2004


please let's not try to be so "trigger happy" when committing... We 
have a million of classes and removing one parameter or changing one 
reference in one class might affect a lot of others and potentially 
generate untrackable bugs.

When in doubt, please ask. If no answer comes, please wait for a while 
as I might no be available all the time :-)

Oscar

On 30 Dec 2004, at 13:29, Benjamin Krause wrote:

> oscar at devel.plogworld.net wrote:
>
>> Author: oscar
>> Date: 2004-12-30 10:58:06 +0000 (Thu, 30 Dec 2004)
>> New Revision: 619
>> Modified:
>>    plog/trunk/class/plugin/pluginbase.class.php
>> Log:
>> in revision 617 we removed a call-by-reference but that reference was 
>> there for a reason... I've added the reference to the function 
>> parameter, because that's where it should be! (but please be careful 
>> when removing references!!)
>
> i see.. yes, didnt fully read the code .. there is a function 
> setBlogInfo() with a reference parameter in the pluginmanager
> class, but obviously the call was made to the specific plugin,
> which is derived from pluginbase ..
>
> i'll try to look closer next time :)
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>




More information about the pLog-svn mailing list