[pLog-svn] r607 - plog/trunk/class/template

Oscar Renalias oscar at renalias.net
Wed Dec 29 20:53:10 GMT 2004


>> But how about these formatting differences in the diff? Is there a 
>> way we can avoid them? Otherwise diffs will grow really big and even 
>> worse, useless because it'll be really difficult to spot what was 
>> actually changed in between of so many tabs and spaces removed... Did 
>> your editor redo the formatting for you or did you do it yourself?
>
> i did it myself.. i'm using vim .. but i cant read the code with a
> text only editor if the formatting is broken the way it is .. maybe
> some IDE will ignore the different formattings.. but my text editor
> cant.. i see that this might become an issue .. maybe i'll just 
> reformat
> all files and commit them without acutally changing code.. just
> to have all files formatted correctly..
>
> what do you think?

Sorry, I don't like the idea too much. My ide is capable of handling 
these things and the problem is that if you fix it now, next time I 
edit things in emacs (sometimes I log into devel.plogworld.net and work 
from there -- like when I'm bored in the office and have nothing better 
to do :-)) they'll break again and we'll need one commit for the 
changes plus one commit to fix the formatting that got broken... I 
suggest that we either find a php code beautifier or fix things as they 
come, but I am not really willing to run a massive code reformatting 
task manually, too much trouble if you ask me.

Oscar




More information about the pLog-svn mailing list